Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed error-logging in example/backup_vm.py for the case that a backup isn't ready. #79

Merged
merged 4 commits into from
Aug 23, 2022
Merged

Fixed error-logging in example/backup_vm.py for the case that a backup isn't ready. #79

merged 4 commits into from
Aug 23, 2022
+2 −1

Conversation

rokkbert
Copy link
Contributor

Fixed error-logging in example/backup_vm.py for the case that a backup isn't ready.

The symptom was the following error, when a backup of the VM wasn't in state READY:

backup_vm.py", line 224, in cmd_download
    raise RuntimeError("Backup {} is not ready".format(backup_uuid))
NameError: name 'backup_uuid' is not defined

Signed-off-by: Rob Linden [email protected]

rokkbert added 2 commits July 13, 2022 12:44
@rokkbert
Deleted old examples which worked for oVirt 4.2 but are incompatible …

Verified

This commit was signed with the committer’s verified signature.
mlschroe Michael Schroeder
GPG key ID: 60417D8AEF05C1D0
Verified
Learn about vigilant mode
c112d00 
…with current versions.

Signed-off-by: Rob Linden [email protected]
@rokkbert
Fixed error-logging in example/backup_vm.py for the case that a backu…
ad8b15d 
…p isn't ready.

Signed-off-by: Rob Linden [email protected]
@rokkbert rokkbert requested review from oliel and mnecas as code owners August 22, 2022 11:53
@aesteve-rh
Copy link
Member

aesteve-rh commented Aug 23, 2022 •
edited
Loading

The patch looks good, but there is an extra commit with a merge that can be skipped (i,e,. 20c6cc7).

Please rebase the branch with upstream instead.

barpavel
barpavel approved these changes Aug 23, 2022
View reviewed changes
barpavel
barpavel reviewed Aug 23, 2022
View reviewed changes
@barpavel barpavel self-requested a review August 23, 2022 13:01
barpavel
barpavel approved these changes Aug 23, 2022
View reviewed changes
Copy link
Member

@barpavel barpavel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mnecas mnecas merged commit 099e7e4 into oVirt:main Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnecas mnecas

@barpavel barpavel

@oliel oliel

@bennyz bennyz

@aesteve-rh aesteve-rh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rokkbert @aesteve-rh @mnecas @barpavel