Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pass file-system-derived hostname to host configurations #99

Merged
merged 1 commit into from
Mar 24, 2025
Merged

pass file-system-derived hostname to host configurations #99

merged 1 commit into from
Mar 24, 2025
+15 −11

Conversation

phaer
Copy link
Member

@phaer phaer commented Mar 20, 2025

This aims to provide the features asked for in #96 with two notable differences:

  • we don't set any nixos options but empower users to do so by passing the hostname along
  • we do so for nix-darwin and system-manager systems as well.

docs are updated to reflect the change.

cc @yajo

@phaer phaer requested a review from zimbatm March 20, 2025 08:59
@phaer phaer mentioned this pull request Mar 20, 2025
Closed
zimbatm
zimbatm reviewed Mar 20, 2025
View reviewed changes
yajo
yajo approved these changes Mar 23, 2025
View reviewed changes
Copy link
Contributor

@yajo yajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good solution.

@zimbatm zimbatm merged commit 5663ede into numtide:main Mar 24, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimbatm zimbatm zimbatm left review comments

@yajo yajo yajo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phaer @zimbatm @yajo