fix auth_secret identify option on python3 #217
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The root issue is that on python3 there are conflicting type assertions for auth_secret:
in #202, @ericb proposed just changing the initial type assertion to allow
bytes_types
instead ofstring_types
. I'm fine with that, but I think it might be more "natural" to allow a string forauth_secret
as well, so I've come up with my own variation usingto_bytes
.(pushing just the test first to demonstrate failures, then the fix ...)