Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: update Travis-CI test matrix / lib versions #211

Merged
merged 3 commits into from
Jul 8, 2018

Conversation

ploxiln
Copy link
Member

@ploxiln ploxiln commented Jul 7, 2018

I think we can reduce the overall test matrix by not testing everything with everything, but rather being a bit more judicious.

Includes small bumps to to snappy and tornado 4.5.z, removes dependency on simplejson.

Adds experimental python3.7 support, probably a good idea to defer this bit to a follow-up PR ...

@ploxiln ploxiln force-pushed the update_test_versions branch 7 times, most recently from 8f1fadf to 4dc8ff3 Compare July 7, 2018 16:31
@ploxiln
Copy link
Member Author

ploxiln commented Jul 7, 2018

cc @jehiah @mreiferson

I could move the python3.7 stuff to a separate follow-up PR, we could put it off until after the next release.

@ploxiln
Copy link
Member Author

ploxiln commented Jul 7, 2018

(tornado-5.0 compatibility is probably more important, but also more work, so I figured I'd attack this first :)

@ploxiln ploxiln force-pushed the update_test_versions branch 3 times, most recently from 6598be2 to 038f05c Compare July 7, 2018 23:25
@jehiah
Copy link
Member

jehiah commented Jul 8, 2018

@ploxiln generally LGTM; do you want to land 855802d and 0a4542e separately?

@ploxiln
Copy link
Member Author

ploxiln commented Jul 8, 2018

Yeah, I'll split them out to a separate PR.

ploxiln added 2 commits July 7, 2018 23:40
update snappy to 1.1.7 and cmake build

update tornado 4.5.z to 4.5.3
drop tornado 4.1

trim test matrix - no need to test all tornado/nsq combinations
add python3.4
use ubuntu "xenial" for one of the python3.6 test runs
@ploxiln ploxiln force-pushed the update_test_versions branch from 038f05c to 0853bd2 Compare July 8, 2018 03:41
two unrelated changes:

no longer try to use simplejson, python2.7+ has json in stdlib

setup.py tests_require updates:
 - additional to install_requires, so no need to repeat tornado here
 - needs certifi for tornado.simple_httpclient._default_ca_certs()
   (even though tornado 4.4+ does not need that function on modern python)
 - make sure pytest stays < 4.0 because
   Metafunc.addcall is deprecated and scheduled to be removed in pytest 4.0.
   Please use Metafunc.parametrize instead.
@ploxiln ploxiln force-pushed the update_test_versions branch from 0853bd2 to a145043 Compare July 8, 2018 03:44
@ploxiln
Copy link
Member Author

ploxiln commented Jul 8, 2018

removed python3.7 stuff, squashed more, ready for merge

@ploxiln ploxiln merged commit d88fbef into nsqio:master Jul 8, 2018
@ploxiln
Copy link
Member Author

ploxiln commented Jul 8, 2018

python3.7 stuff now in #212

@ploxiln ploxiln deleted the update_test_versions branch July 9, 2018 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants