-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: update Travis-CI test matrix / lib versions #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8f1fadf
to
4dc8ff3
Compare
I could move the python3.7 stuff to a separate follow-up PR, we could put it off until after the next release. |
(tornado-5.0 compatibility is probably more important, but also more work, so I figured I'd attack this first :) |
6598be2
to
038f05c
Compare
Yeah, I'll split them out to a separate PR. |
update snappy to 1.1.7 and cmake build update tornado 4.5.z to 4.5.3 drop tornado 4.1 trim test matrix - no need to test all tornado/nsq combinations add python3.4 use ubuntu "xenial" for one of the python3.6 test runs
038f05c
to
0853bd2
Compare
two unrelated changes: no longer try to use simplejson, python2.7+ has json in stdlib setup.py tests_require updates: - additional to install_requires, so no need to repeat tornado here - needs certifi for tornado.simple_httpclient._default_ca_certs() (even though tornado 4.4+ does not need that function on modern python) - make sure pytest stays < 4.0 because Metafunc.addcall is deprecated and scheduled to be removed in pytest 4.0. Please use Metafunc.parametrize instead.
0853bd2
to
a145043
Compare
removed python3.7 stuff, squashed more, ready for merge |
python3.7 stuff now in #212 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we can reduce the overall test matrix by not testing everything with everything, but rather being a bit more judicious.
Includes small bumps to to snappy and tornado 4.5.z, removes dependency on simplejson.
Adds experimental python3.7 support, probably a good idea to defer this bit to a follow-up PR ...