Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warnings #189

Merged
merged 2 commits into from
Aug 4, 2017
Merged

Deprecation warnings #189

merged 2 commits into from
Aug 4, 2017

Conversation

misja
Copy link
Contributor

@misja misja commented Aug 3, 2017

Both cgi.parse_qs and inspect.getargspec will be deprecated. This pull will replace these with urllib.parse.parse_qs and inspect.signature respectively if available.

@mreiferson
Copy link
Member

@misja looks good to me, thanks!

@mreiferson mreiferson merged commit 26ca527 into nsqio:master Aug 4, 2017
@misja misja deleted the deprecated branch August 5, 2017 11:25
@misja
Copy link
Contributor Author

misja commented Aug 8, 2017

@mreiferson if you intend to create a release including this change, please hold since I just noticed two issues with replacing inspect.getargspec by inspect.signature -

  • the change tries to load inspect.getargspec first which will still trigger the deprecated warning
  • I naively assumed the return type of inspect.signature would be equal to inspect.getargspec but it is not and will break things (tests, tests, ...)

I'll add a proper pull second half next week to have this sorted.

@mreiferson
Copy link
Member

Thanks for validating and giving us the heads up, I'll wait for your PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants