Add SIGINT handler #130
Merged
Add SIGINT handler #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds in a SIGINT handler, to ensure that ctrl-c, is caught in the nsq.run() loop.
|
👍 @jehiah do you recall any reason why we didn't add this initially? (I couldn't remember) |
|
One possible reason I can think of is so there's an easy way to "terminate faster", but still let python clean itself up and maybe print a backtrace. That might not be a great reason though. Maybe it was just an oversight. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds in a SIGINT handler, to ensure that ctrl-c, is caught in the
nsq.run() loop.
@mreiferson this is a follow up from our conversation, let me know if there's anything else you'd like to see documented and/or anything else that needs to be done to get this pushed through.