Snappy socket undeclared variable #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks like an actual bug, but it's an easy fix |
|
RFR @jehiah |
jehiah
added a commit
that referenced
this pull request
Sep 2, 2015
Snappy socket undeclared variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure how to reproduce this issue. I am using snappy for writing to nsqd but not when reading, maybe that is what's causing this issue.
WARNING:tornado.general:error on read
Traceback (most recent call last):
File "/usr/local/lib/python2.7/dist-packages/tornado/iostream.py", line 644, in _handle_read
pos = self._read_to_buffer_loop()
File "/usr/local/lib/python2.7/dist-packages/tornado/iostream.py", line 614, in _read_to_buffer_loop
if self._read_to_buffer() == 0:
File "/usr/local/lib/python2.7/dist-packages/tornado/iostream.py", line 726, in _read_to_buffer
chunk = self.read_from_fd()
File "/usr/local/lib/python2.7/dist-packages/tornado/iostream.py", line 1005, in read_from_fd
chunk = self.socket.recv(self.read_chunk_size)
File "/usr/local/lib/python2.7/dist-packages/nsq/snappy_socket.py", line 23, in recv
return self._recv(size, self._socket.recv)
File "/usr/local/lib/python2.7/dist-packages/nsq/snappy_socket.py", line 36, in _recv
if not uncompressed:
UnboundLocalError: local variable 'uncompressed' referenced before assignment