Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reader: add msg_timeout IDENTIFY option #126

Merged
merged 1 commit into from
May 7, 2015
Merged

reader: add msg_timeout IDENTIFY option #126

merged 1 commit into from
May 7, 2015

Conversation

mreiferson
Copy link
Member

rfr @jehiah

jehiah
jehiah reviewed May 7, 2015
View reviewed changes
nsq/async.py
@@ -153,6 +159,7 @@ def __init__(
assert isinstance(auth_secret, (str, unicode, None.__class__))
assert tls_v1 and ssl or not tls_v1, \
'tls_v1 requires Python 2.6+ or Python 2.5 w/ pip install ssl'
assert msg_timeout is None or (isinstance(msg_timeout, int) and msg_timeout > 0)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allow float too and cast to int?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@mreiferson
Copy link
Member Author

floated

jehiah added a commit that referenced this pull request May 7, 2015
@jehiah
Merge pull request #126 from mreiferson/msg_timeout_126
b415cf0 
reader: add msg_timeout IDENTIFY option
@jehiah jehiah merged commit b415cf0 into nsqio:master May 7, 2015
@mreiferson mreiferson deleted the msg_timeout_126 branch May 7, 2015 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mreiferson @jehiah