NC | Backports - 5.18.z #8881
Merged
NC | Backports - 5.18.z #8881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shirady
reviewed
Mar 24, 2025
romayalon
force-pushed
the
romy-backports-5.18
branch
from
56045cb to
68e7fd2
Compare
romayalon
force-pushed
the
romy-backports-5.18
branch
from
68e7fd2 to
5353490
Compare
Signed-off-by: Romy <[email protected]> (cherry picked from commit 9071a54)
Signed-off-by: Romy <[email protected]> (cherry picked from commit 82cd296)
Signed-off-by: nadav mizrahi <[email protected]> (cherry picked from commit 48a908e)
Signed-off-by: nadav mizrahi <[email protected]> (cherry picked from commit 2f27896)
Signed-off-by: naveenpaul1 <[email protected]> (cherry picked from commit f779b82)
Signed-off-by: Romy <[email protected]> (cherry picked from commit 79ed147)
…eration 1. Replace the function stat_ignore_eacces with stat_if_exists and add ignore of ENOENT and ENOTDIR (in addition to EACCES with a flag of config.EACCES_IGNORE_ENTRY). 2. Call stat on the entry_path one time and save is instead of calling it in concurrency so that we can be sure that the value was not deleted from the result array. Move the stat call before results.push(r) and results.splice(pos, 0, r) as they both add a result to the array. 3. Add a comment before the check_access, see also in PR description of Added check_access() call to list objects noobaa#6576. This change is continuing PR noobaa#8751 by adding a case to ignore a stat failure entry. Signed-off-by: shirady <[email protected]> (cherry picked from commit fe4115c)
Signed-off-by: Romy <[email protected]>
romayalon
force-pushed
the
romy-backports-5.18
branch
from
5353490 to
625cbe6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the Problem
Explain the Changes
Backport of the following PRs to 5.18.z (5.18.2) -
.jsonsuffix #8806Issues: Fixed #xxx / Gap #xxx
Testing Instructions: