Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle ClassCastException #374

Closed
wants to merge 1 commit into from
Closed

Handle ClassCastException #374

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions .../src/org/robotframework/ide/eclipse/main/plugin/tableeditor/source/SuiteSourceEditor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,10 +211,12 @@ private void updateLineLocationStatusBar(final int caretPosition) {
final int columnNumber = caretPosition - document.getLineOffset(lineNumber) + 1;
lineNumber++;

final StatusLineContributionItem find = (StatusLineContributionItem) getEditorSite().getActionBars()
.getStatusLineManager()
.find(ITextEditorActionConstants.STATUS_CATEGORY_INPUT_POSITION);
find.setText(lineNumber + ":" + columnNumber);
IContributionItem find = getEditorSite().getActionBars()
.getStatusLineManager()
.find(ITextEditorActionConstants.STATUS_CATEGORY_INPUT_POSITION);
if (find instanceof StatusLineContributionItem) {
find.setText(lineNumber + ":" + columnNumber);
}
} catch (final BadLocationException e) {
RedPlugin.logError("Unable to get position in source editor in order to update status bar", e);
}
Expand All @@ -223,11 +225,13 @@ private void updateLineLocationStatusBar(final int caretPosition) {
private void updateLineDelimitersStatus() {
final IDocument document = getDocument();

final StatusLineContributionItem find = (StatusLineContributionItem) getEditorSite().getActionBars()
IContributionItem find = getEditorSite().getActionBars()
.getStatusLineManager()
.find(RobotFormEditorActionBarContributor.DELIMITERS_INFO_ID);
final String delimiter = DocumentUtilities.getDelimiter(document);
find.setText("\r\n".equals(delimiter) ? "CR+LF" : "LF");
.find(ITextEditorActionConstants.STATUS_CATEGORY_INPUT_POSITION);
if (find instanceof StatusLineContributionItem) {
final String delimiter = DocumentUtilities.getDelimiter(document);
find.setText("\r\n".equals(delimiter) ? "CR+LF" : "LF");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this compile?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surely it will not compile, similarly as line 218

Copy link
Author

@spirentitestdevter spirentitestdevter Jun 29, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michalanglart
Sorry, Can you update as below for me ? Thanks.
private void updateLineLocationStatusBar(final int caretPosition) {
try {
final IDocument document = getDocument();
int lineNumber = document.getLineOfOffset(caretPosition);
final int columnNumber = caretPosition - document.getLineOffset(lineNumber) + 1;
lineNumber++;

        final IContributionItem find = getEditorSite().getActionBars()
                .getStatusLineManager()
                .find(ITextEditorActionConstants.STATUS_CATEGORY_INPUT_POSITION);
        if (find instanceof StatusLineContributionItem) {
			((StatusLineContributionItem )find).setText(lineNumber + ":" + columnNumber);
		}
    } catch (final BadLocationException e) {
        RedPlugin.logError("Unable to get position in source editor in order to update status bar", e);
    }
}

private void updateLineDelimitersStatus() {
    final IDocument document = getDocument();

    final IContributionItem find = getEditorSite().getActionBars()
            .getStatusLineManager()
            .find(RobotFormEditorActionBarContributor.DELIMITERS_INFO_ID);
	if (find instanceof StatusLineContributionItem) {
		final String delimiter = DocumentUtilities.getDelimiter(document);
		((StatusLineContributionItem )find).setText("\r\n".equals(delimiter) ? "CR+LF" : "LF");
	}
}

}
}

private void installBreakpointTogglingOnDoubleClick() {
Expand Down