Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SRE-777 add helm chart for N9 Agent #1

Merged
merged 16 commits into from
May 26, 2022

Conversation

RemiLis
Copy link
Contributor

@RemiLis RemiLis commented May 10, 2022

No description provided.

@triluch triluch self-requested a review May 10, 2022 15:39
@RemiLis RemiLis marked this pull request as ready for review May 11, 2022 12:49
@ian-bartholomew
Copy link
Contributor

Added a codefresh config and codeowners files. There are a couple of quick linting fixes

Copy link
Contributor

@triluch triluch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some cosmetics and kube-linter issues left. After adding fixes for linter, make sure you test if the agent works with some queries defined for its datasource (for example it may fail if it tries to put some temporary files somewhere we don't expect).
For default limits I would suggest something along the lines of 1core and 1Gi mem (it depends on number of queries defined for DS, so it's not like one size suits all).
Other that what kube-linter found I would also add allowPrivilegeEscalation: false in security context.

@RemiLis
Copy link
Contributor Author

RemiLis commented May 19, 2022

@triluch Thanks Andrzej I have added all tips from kube-linter and also allowPrivilegeEscalation one

Copy link
Contributor

@triluch triluch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just make sure agents works okay with those security changes and we can go ;)

@RemiLis RemiLis merged commit ed54023 into main May 26, 2022
@kgreczka9 kgreczka9 deleted the SRE-777-create-helm-chart-for-agent branch August 30, 2022 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants