-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SRE-777 add helm chart for N9 Agent #1
Conversation
Co-authored-by: Andrzej Voss <[email protected]>
Co-authored-by: Andrzej Voss <[email protected]>
Co-authored-by: Andrzej Voss <[email protected]>
Added a codefresh config and codeowners files. There are a couple of quick linting fixes |
…9/helm-charts into SRE-777-create-helm-chart-for-agent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some cosmetics and kube-linter
issues left. After adding fixes for linter, make sure you test if the agent works with some queries defined for its datasource (for example it may fail if it tries to put some temporary files somewhere we don't expect).
For default limits I would suggest something along the lines of 1core and 1Gi mem (it depends on number of queries defined for DS, so it's not like one size suits all).
Other that what kube-linter
found I would also add allowPrivilegeEscalation: false
in security context.
Co-authored-by: Andrzej Voss <[email protected]>
Co-authored-by: Andrzej Voss <[email protected]>
@triluch Thanks Andrzej I have added all tips from kube-linter and also allowPrivilegeEscalation one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just make sure agents works okay with those security changes and we can go ;)
No description provided.