Luks btrfs raid example #806
Merged
+92
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iFreilicht
force-pushed
the
luks-btrfs-raid-example
branch
from
5763c39 to
0fda953
Compare
iFreilicht
force-pushed
the
luks-btrfs-raid-example
branch
from
0fda953 to
b9c9948
Compare
Lassulus
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #802
Fixes #799
I actually feel the example was useful, spreading a btrfs atop two encrypted volumes is not trivial, and while testing I actually discovered that the alphabetical order of the devices matters here, see comment in the code. Not sure if that's something our tests cover yet.
I would've pushed to the original PR but it had the upstream set to master, which I can't push to, even with the "Allow maintainers to edit the PR" flag set.
I've left the original commit intact but can squash if necessary.