make-disk-image: use OVMF efi always #643
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building disk images, the VM used to perform partitioning/mkfs inherits the kernel from the nixosConfiguration we're trying to build for. This works fine, until you try to boot a kernel with
zboot
, and in that case you need UEFI to load the image, otherwise you end up with the following log from QEMU:"unable to handle EFI zboot image with ... compression"
https://github.com/qemu/qemu/blob/master/hw/core/loader.c#L924
Loading OVMF allows us to bypass this issue, and boot the kernel successfully like this:
I think the architecture of inheriting the host kernel just to make a disk image from a nixosConfiguration might still be a bit wrong. But this PR fixes the issue for the time being.