feat: Add missing TF backends #766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjholm
commented
Mar 27, 2025
Comment on lines
276
to
+295
| case "gcs": | ||
| gcsConfig := &cdktf.GcsBackendConfig{} | ||
| // serialize the backend config | ||
| err := json.Unmarshal(jsonMap, gcsConfig) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| cdktf.NewGcsBackend(stack, gcsConfig) | ||
| err = configureTfBackend(stack, config, cdktf.NewGcsBackend) | ||
| case "s3": | ||
| s3Config := &cdktf.S3BackendConfig{} | ||
| // serialize the backend config | ||
| err := json.Unmarshal(jsonMap, s3Config) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| cdktf.NewS3Backend(stack, s3Config) | ||
| err = configureTfBackend(stack, config, cdktf.NewS3Backend) | ||
| case "azurerm": | ||
| err = configureTfBackend(stack, config, cdktf.NewAzurermBackend) | ||
| case "http": | ||
| err = configureTfBackend(stack, config, cdktf.NewHttpBackend) | ||
| case "remote": | ||
| err = configureTfBackend(stack, config, cdktf.NewRemoteBackend) | ||
| case "local": | ||
| err = configureTfBackend(stack, config, cdktf.NewLocalBackend) | ||
| case "consul": | ||
| err = configureTfBackend(stack, config, cdktf.NewConsulBackend) | ||
| case "cos": | ||
| err = configureTfBackend(stack, config, cdktf.NewCosBackend) | ||
| case "oss": | ||
| err = configureTfBackend(stack, config, cdktf.NewOssBackend) | ||
| case "pg": | ||
| err = configureTfBackend(stack, config, cdktf.NewPgBackend) |
There was a problem hiding this comment.
tried including these in a generic map, but it was a non-starter so have just made it a switch instead.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #766 +/- ##
=======================================
Coverage 48.75% 48.75%
=======================================
Files 28 28
Lines 3546 3546
=======================================
Hits 1729 1729
Misses 1698 1698
Partials 119 119
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jyecusch
approved these changes
Mar 27, 2025
davemooreuws
approved these changes
Mar 28, 2025
|
🎉 This PR is included in version 1.21.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds all missing valid TF backends for configuration except for kubernetes (couldn't locate constructor for it in cdktf.