Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add deployment name and version to _update calls #610

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Megalonia
Copy link
Collaborator

What

Describe what the change is solving
Plumbs deployment into update params

How

Describe the solution
assign deployment field of prama to ngrok-api-go deployment obj

Breaking Changes

Are there any breaking changes in this PR?

@Megalonia Megalonia requested a review from a team as a code owner March 18, 2025 18:14
@github-actions github-actions bot added the area/controller Issues dealing with the controller label Mar 18, 2025
Copy link

codecov bot commented Mar 18, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 26.99%. Comparing base (deffb4a) to head (366960a).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
.../controller/ngrok/kubernetesoperator_controller.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #610      +/-   ##
==========================================
- Coverage   29.21%   26.99%   -2.23%     
==========================================
  Files          92       92              
  Lines       14549    14608      +59     
==========================================
- Hits         4251     3943     -308     
- Misses      10051    10439     +388     
+ Partials      247      226      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Megalonia Megalonia marked this pull request as draft March 20, 2025 14:20
@Megalonia Megalonia changed the title pass deployment name on update add deployment name and version to _update calls Mar 20, 2025
@jonstacks jonstacks added this to the controller-0.16.0 milestone Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/controller Issues dealing with the controller
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants