Consume IngressEndpoint from status #607
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #607 +/- ##
==========================================
+ Coverage 26.99% 27.08% +0.08%
==========================================
Files 92 92
Lines 14604 14627 +23
==========================================
+ Hits 3943 3962 +19
- Misses 10435 10439 +4
Partials 226 226 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ad of operator spec
masonj5n
force-pushed
the
mason/consume-ingress-endpoint-from-status
branch
from
1b3f175 to
4aee420
Compare
masonj5n
force-pushed
the
mason/consume-ingress-endpoint-from-status
branch
from
4aee420 to
5155270
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
We're moving ingress endpoints to be something that's always provided by the ngrok api instead of something configurable by the user. This change starts using the ingress endpoint that's set on the KubernetesOperator status instead of the one on the spec.
We'll (eventually) remove it from the spec and chart.
How
Get the ingress url off the status instead of spec.
Breaking Changes
If you have a very old operator that hasn't ever gotten the ingress endpoint from the API it may stop working, but any update from the controller should fill it in.