Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set operator description from values.yaml description #605

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

masonj5n
Copy link
Member

@masonj5n masonj5n commented Mar 11, 2025

What

Currently the KubernetesOperator resource always sets its Description field based on the default value for the crd. Since we're asking users for description in values.yaml, we should set it based on that instead.

How

Set description from Values.description.

Breaking Changes

Nope!

@masonj5n masonj5n requested a review from a team as a code owner March 11, 2025 22:10
@github-actions github-actions bot added the area/controller Issues dealing with the controller label Mar 11, 2025
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 26.57%. Comparing base (55e472f) to head (63cffb7).

Files with missing lines Patch % Lines
cmd/api/main.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #605      +/-   ##
==========================================
- Coverage   26.58%   26.57%   -0.01%     
==========================================
  Files          92       92              
  Lines       14549    14553       +4     
==========================================
  Hits         3868     3868              
- Misses      10446    10450       +4     
  Partials      235      235              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/controller Issues dealing with the controller
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant