QuickJS: xml module.

[xeioex]

No description provided.

[Copilot]

Pull Request Overview

This PR introduces a comprehensive set of tests for the new XML module, including parsing, canonicalization, modification, external entity handling, and SAML signature verification. Changes include adding and updating XML tests in the test/xml directory, updating the workflow dependencies to include libxml2-dev for i386, and refining file system tests in test/fs/methods.t.mjs to conditionally skip tests for QuickJS.

Reviewed Changes

Copilot reviewed 6 out of 10 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
test/xml/xml.t.mjs	Adds extensive tests for XML parsing, canonicalization, modification, and error handling.
.github/workflows/check-pr.yml	Updates dependency installation to include libxml2-dev:i386 along with other required packages.
test/xml/external_entity_ignored.t.js	Removes the compatXml.js include and adjusts the condition to run the test without checking has_xml().
test/xml/saml_verify.t.mjs	Updates the SAML verification tests to import xml directly and adjusts error message handling and skip logic.
test/fs/methods.t.mjs	Adds a QuickJS detection helper and updates file system tests to conditionally skip tests under QuickJS.

Files not reviewed (4)

• auto/qjs_modules: Language not supported
• external/njs_xml_module.c: Language not supported
• src/qjs.h: Language not supported
• src/test/njs_unit_test.c: Language not supported

Comments suppressed due to low confidence (2)

test/xml/external_entity_ignored.t.js:16

• Removing the has_xml() check may cause the test to run even when the xml module is unavailable. Consider verifying that the xml module is always present or reinstate the condition if necessary.

if (has_njs()) {

test/xml/saml_verify.t.mjs:277

• Removing the has_xml() condition in the skip function could lead to test execution in environments without the xml module. Please ensure the xml module is consistently available in the test environment or adjust the condition accordingly.

skip: () => (!has_njs() || !has_webcrypto()),

[VadimZhestikov]

Looks good