Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for pid_mode #189

Merged
merged 1 commit into from
Oct 12, 2018
Merged

Add support for pid_mode #189

merged 1 commit into from
Oct 12, 2018

Conversation

aughr
Copy link
Contributor

@aughr aughr commented Oct 12, 2018

Also adds a bit of coverage for network_mode.

@aughr aughr requested a review from intjonathan October 12, 2018 19:33
@intjonathan
Copy link
Contributor

Code seems legit. Can you add a block in the README?

@aughr
Copy link
Contributor Author

aughr commented Oct 12, 2018

Whoops, yes.

@aughr
Add support for pid_mode
c81e386 
Also adds a bit of coverage for network_mode.
@aughr
Copy link
Contributor Author

aughr commented Oct 12, 2018

@intjonathan Done!

@aughr aughr merged commit 1dacf22 into master Oct 12, 2018
@aughr aughr deleted the pid_mode branch October 12, 2018 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@intjonathan intjonathan intjonathan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aughr @intjonathan