Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support labels for containers #170

Merged
merged 1 commit into from
Jan 27, 2017
Merged

Conversation

relistan
Copy link
Collaborator

@relistan relistan commented Apr 25, 2016

This PR adds basic support (without interpolation) for labels at deployment time. These are useful in pretty much all modern Docker deployments.

cc @dselans

@dselans
Copy link
Contributor

dselans commented Apr 25, 2016

What's going to happen when you use labels but deploy to hosts that do not support labels?

@relistan
Copy link
Collaborator Author

Try it, I don't know and I don't have access to a 1.5 Docker daemon to try it. I think Docker will just ignore them.

@relistan
Copy link
Collaborator Author

relistan commented May 9, 2016

Want to merge this, but don't want to break things for you @dselans

@relistan
Copy link
Collaborator Author

relistan commented Jun 9, 2016

@actaeon I'd love to merge this but don't want to break things for you guys running Docker 1.5. I don't have 1.5 to test with. Can you or someone else there validate it? Much appreciated.

@actaeon
Copy link
Contributor

actaeon commented Jun 9, 2016

@relistan offsite this week :) , will look at it Monday.

@relistan
Copy link
Collaborator Author

Thanks @actaeon !

@relistan
Copy link
Collaborator Author

Ping @actaeon

@relistan
Copy link
Collaborator Author

@intjonathan @actaeon @spkane can one of you guys let me know if this is mergeable? Thanks!

@intjonathan
Copy link
Contributor

Docker 1.5 is very much end of life, we're not running it internally any longer and at this point it seems nobody should. Concerns about compatibility with it have expired too.

@intjonathan
Copy link
Contributor

@relistan Can you weigh in on whether this should be in a 1.9 or 1.8.10?

@relistan
Copy link
Collaborator Author

@intjonathan good, glad no one is running 1.5 :) . Since this is a minor feature addition I'd ship it as 1.8.10. 👍

@intjonathan intjonathan merged commit 797416c into newrelic:master Jan 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants