-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support labels for containers #170
Conversation
What's going to happen when you use labels but deploy to hosts that do not support labels? |
Try it, I don't know and I don't have access to a 1.5 Docker daemon to try it. I think Docker will just ignore them. |
Want to merge this, but don't want to break things for you @dselans |
@actaeon I'd love to merge this but don't want to break things for you guys running Docker 1.5. I don't have 1.5 to test with. Can you or someone else there validate it? Much appreciated. |
@relistan offsite this week :) , will look at it Monday. |
Thanks @actaeon ! |
Ping @actaeon |
@intjonathan @actaeon @spkane can one of you guys let me know if this is mergeable? Thanks! |
Docker 1.5 is very much end of life, we're not running it internally any longer and at this point it seems nobody should. Concerns about compatibility with it have expired too. |
@relistan Can you weigh in on whether this should be in a 1.9 or 1.8.10? |
@intjonathan good, glad no one is running 1.5 :) . Since this is a minor feature addition I'd ship it as 1.8.10. 👍 |
This PR adds basic support (without interpolation) for labels at deployment time. These are useful in pretty much all modern Docker deployments.
cc @dselans