Do not revert custom container name #128
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The readme states you can override the container name by doing something like:
This doesn't seem to work. When you do that, you still get a container named the same as the project.
There are tests around it, but
bin/centurion
was messing it up, which is untested. I added some integration tests that actually spin up a Vagrant box and runs Centurion against it. I've excluded them from the the defaultrake
andrspec
runs. You can run them first runningvagrant up
and then runningrake integration
.I'm not sold on keeping them, but this is something I've been using to troubleshoot this, and other problems I'm finding. It might be good to have working end to end examples.
At the very least, the fix to
bin/centurion
needs to be made.