Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not revert custom container name #128

Conversation

MarkBorcherding
Copy link
Contributor

The readme states you can override the container name by doing something like:

  task :common do
    set :name, 'backend'
    # ...
  end

This doesn't seem to work. When you do that, you still get a container named the same as the project.

There are tests around it, but bin/centurion was messing it up, which is untested. I added some integration tests that actually spin up a Vagrant box and runs Centurion against it. I've excluded them from the the default rake and rspec runs. You can run them first running vagrant up and then running rake integration.

I'm not sold on keeping them, but this is something I've been using to troubleshoot this, and other problems I'm finding. It might be good to have working end to end examples.

At the very least, the fix to bin/centurion needs to be made.

@relistan
Copy link
Collaborator

Hi @MarkBorcherding you are right this it broken! I'd like to not introduce all this other stuff but bring in the fix. There's not a single commit I can cherry pick so I'm going to close this and merge make the fix myself. I agree we need end-to-end tests, but as is I don't see how to merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants