Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add options to the legacy route converter #14802

Merged
merged 1 commit into from
Mar 19, 2025

Conversation

kamilmysliwiec
Copy link
Member

@kamilmysliwiec kamilmysliwiec commented Mar 19, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kamilmysliwiec kamilmysliwiec merged commit 1e412cb into master Mar 19, 2025
2 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build f299d3d7-13c9-459a-b181-c45dcabd9b5b

Details

  • 3 of 6 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 89.294%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/core/router/legacy-route-converter.ts 3 6 50.0%
Totals Coverage Status
Change from base Build 85a739d2-3518-46d4-be1b-5c7d3550fc77: 0.002%
Covered Lines: 7148
Relevant Lines: 8005

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants