fix(core): revisit dependencies w/ possibly higher distance

[clkamp]

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our guidelines: https://github.com/nestjs/nest/blob/master/CONTRIBUTING.md
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Other... Please describe:

What is the current behavior?

Issue Number: #14096

What is the new behavior?

The module distance is reevaluated when the module is not within the modules visited in the current depth search. This should be enough to avoid endless loops on cyclic dependency graphs. However, modules that have dependency paths of different length are now evaluated to the higher distance.

Does this PR introduce a breaking change?

• Yes
• No

Other information

[coveralls]

Pull Request Test Coverage Report for Build c981fc60-fb24-410d-bf21-d0e1e65b9f9b

Details

• 4 of 5 (80.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 92.243%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
packages/core/scanner.ts	4	5	80.0%

Totals
Change from base Build 3047ae8a-a5a4-402c-9e7d-49c14e1ba997:	0.0%
Covered Lines:	6754
Relevant Lines:	7322

---

💛 - Coveralls

[arabold]

Just ran into this today as well and can confirm that the fixes my issue. Now my database service is properly initialized before being used in other modules. 👍

[Vue-Pu]

Closes #14097

[Vue-Pu]

@arabold @clkamp review needed to closePR no breaking changes will accur. and fixes #14097