Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: moduleIdGeneratorAlgorithm default value changed, and it can't be controlled in tests #14455

Closed
2 tasks done
rbnayax opened this issue Jan 19, 2025 · 3 comments
Closed
2 tasks done
Labels
needs triage This issue has not been looked into type: bug 😭

Comments

@rbnayax
Copy link
Contributor

rbnayax commented Jan 19, 2025

Did you read the migration guide?

  • I have read the whole migration guide

Is there an existing issue that is already proposing this?

  • I have searched the existing issues

Potential Commit/PR that introduced the regression

PR #13336

NestJS version

11.0.1

Describe the regression

Before v11 the default behavior of moduleIdGeneratorAlgorithm (which didn't really exist) was the hash one.
V11 introduced a reference algorithm and changed it to be the default. This is a regression and is not documented in the non-existing release notes of v11.
Even if we decide that the default value should be changed back, there is currently no way of controlling the value of moduleIdGeneratorAlgorithm in TestingModuleBuilder.
Please change the default value and allow to change the algorithm in TestingModuleBuilder.

Minimum reproduction code

No response

Input code

Expected behavior

change the default algorithm back to hash and allow controlling the algorithm in TestingModuleBuilder

Other

No response

@rbnayax rbnayax added needs triage This issue has not been looked into type: bug 😭 labels Jan 19, 2025
@rbnayax rbnayax changed the title moduleIdGeneratorAlgorithm default value changed, and it can't be controlled in tests regression: moduleIdGeneratorAlgorithm default value changed, and it can't be controlled in tests Jan 19, 2025
@rbnayax
Copy link
Contributor Author

rbnayax commented Jan 19, 2025

@kamilmysliwiec would appreciate your input

@rbnayax
Copy link
Contributor Author

rbnayax commented Jan 19, 2025

fixed in #14456

@kamilmysliwiec
Copy link
Member

Let's track this here #14456

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage This issue has not been looked into type: bug 😭
Projects
None yet
Development

No branches or pull requests

2 participants