Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: ckb-script shall only rely on DefaultMachineRunner trait #4856

Merged

Conversation

xxuejie
Copy link
Collaborator

@xxuejie xxuejie commented Mar 21, 2025

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:

Related changes

  • PR to update owner/repo:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • Performance regression
  • Breaking backward compatibility

Release note

None: Exclude this PR from the release note.
Title Only: Include only the PR title in the release note.
Note: Add a note under the PR title in the release note.

@xxuejie xxuejie requested a review from a team as a code owner March 21, 2025 03:13
@xxuejie xxuejie requested review from quake and removed request for a team March 21, 2025 03:13
@xxuejie
Copy link
Collaborator Author

xxuejie commented Mar 21, 2025

Please note that this PR is pending on nervosnetwork/ckb-vm#469.

However, the Rust code is already ready for review.

@xxuejie xxuejie requested review from eval-exec, zhangsoledad and quake and removed request for quake March 21, 2025 03:14
quake
quake previously approved these changes Mar 24, 2025
eval-exec
eval-exec previously approved these changes Mar 24, 2025
@xxuejie xxuejie dismissed stale reviews from eval-exec and quake via d2b009a March 24, 2025 05:24
@xxuejie
Copy link
Collaborator Author

xxuejie commented Mar 24, 2025

@eval-exec @quake I've updated the PR so a proper release of ckb-vm is used, please re-approve when you see fit.

@xxuejie xxuejie added this pull request to the merge queue Mar 25, 2025
Merged via the queue into nervosnetwork:develop with commit 6bba82e Mar 25, 2025
33 checks passed
@xxuejie xxuejie deleted the ckb-script-should-rely-on-traits branch March 25, 2025 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants