[GrCUDA-HOTFIX] fix install and benchmarks #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwdidonato
reviewed
Sep 26, 2021
README.md
Outdated
| @@ -336,6 +336,12 @@ Run all benchmarks | |||
| graalpython --jvm --polyglot benchmark_wrapper.py -d -i 30 | |||
| ``` | |||
|
|
|||
| To run the CUDA version of all benchmarks, build it as follows. You might want to update the GPU architecture inside `$GRCUDA_HOME/projects/resources/cuda/Makefile` to reflect the hardware at your disposal. | |||
There was a problem hiding this comment.
I think it's just $GRCUDA_HOME/projects/resources/cuda
gwdidonato
reviewed
Sep 26, 2021
| cd $GRCUDA_HOME/projects/resources/cuda; | ||
| make | ||
| ``` | ||
|
|
||
| Run the CUDA version of all benchmarks |
There was a problem hiding this comment.
We should add the location: $GRCUDA_HOME/projects/resources/python/benchmark
gwdidonato
reviewed
Sep 26, 2021
There was a problem hiding this comment.
I made a clean build, and everything work fine.
Both single benchmarks and the wrapper work properly, both in the python and the cuda versions.
I have added a couple of comments in the readme to be fixed.
Also, from students' experience I suggest to refer to the grcuda/oci_setup/setup_machine_from_scratch.sh script in the readme, if following instructions in the readme didn't work properly.
gwdidonato
approved these changes
Sep 26, 2021
AlbertoParravicini
deleted the
GRCUDA-HOTFIX-fix-install-and-benchmarks
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing GRCUDA-67 and GRCUDA-68