Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Consumer Groups and Overflow support #1384

Merged
merged 11 commits into from
Mar 20, 2025
Merged

Add Consumer Groups and Overflow support #1384

merged 11 commits into from
Mar 20, 2025

Conversation

Jarema
Copy link
Member

@Jarema Jarema commented Mar 19, 2025

This PR adds support for Priority Groups as described in ADR: https://github.com/nats-io/nats-architecture-and-design/blob/main/adr/ADR-42.md

Signed-off-by: Tomasz Pietrek [email protected]

@Jarema Jarema requested review from caspervonb and piotrpio March 19, 2025 11:52
Jarema added 7 commits March 19, 2025 14:17
Signed-off-by: Tomasz Pietrek <[email protected]>
Signed-off-by: Tomasz Pietrek <[email protected]>
Signed-off-by: Tomasz Pietrek <[email protected]>
Signed-off-by: Tomasz Pietrek <[email protected]>
Signed-off-by: Tomasz Pietrek <[email protected]>
Signed-off-by: Tomasz Pietrek <[email protected]>
Signed-off-by: Tomasz Pietrek <[email protected]>
Copy link
Contributor

@piotrpio piotrpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one nit

enum
deserialize
PinnedClient
PriorityGroups
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is no longer necessary I think.

Signed-off-by: Tomasz Pietrek <[email protected]>
@Jarema Jarema merged commit c6798de into main Mar 20, 2025
12 checks passed
@Jarema Jarema deleted the consumer-groups branch March 20, 2025 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants