Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove local_time from ActiveTextLogger. Fixes: #2815 #3104

Merged
merged 8 commits into from
Jan 7, 2025

Conversation

AlesKus
Copy link
Contributor

@AlesKus AlesKus commented Jan 5, 2025

Related Issue(s) #2815
Has Unit Tests (y/n) y
Documentation Included (y/n) y

Change Description

Removed invocation of the localtime_r.

Fixed unit tests:

  • included them into build, after they were removed #f797734
  • fixed the LogFile behavior, which, I assume, has been broken here: #58c2141 ; the intention of include_excl flag was to include the O_EXCL option for opening (see source code); therefore include_excl = false means OverwriteType::OVERWRITE. I've mentioned this behavior in the documentation.

Rationale

Fixes #2815.

Testing/Review Recommendations

Please review the documentation changes as well.
How to test: run fprime-util check in Svc/ActiveTextLogger.

Future Work

  1. The component has several TODOs:
  1. The test functions might be split to small test cases.

@LeStarch LeStarch self-requested a review January 6, 2025 20:57
@LeStarch
Copy link
Collaborator

LeStarch commented Jan 6, 2025

Looks very good! Only two minor touch-ups.

@LeStarch
Copy link
Collaborator

LeStarch commented Jan 7, 2025

I went ahead and made the changes. Should be good once it passes CI!

Copy link
Collaborator

@LeStarch LeStarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is using multiple styles to compare strings, so let us leave as is.

@LeStarch LeStarch merged commit f5b1bb0 into nasa:devel Jan 7, 2025
1 check passed
@AlesKus AlesKus deleted the issue-2815 branch January 7, 2025 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove local_time from ActiveTextLogger
2 participants