Remove local_time from ActiveTextLogger. Fixes: #2815 #3104
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Removed invocation of the localtime_r.
Fixed unit tests:
include_excl
flag was to include the O_EXCL option for opening (see source code); thereforeinclude_excl = false
meansOverwriteType::OVERWRITE
. I've mentioned this behavior in the documentation.Rationale
Fixes #2815.
Testing/Review Recommendations
Please review the documentation changes as well.
How to test: run
fprime-util check
inSvc/ActiveTextLogger
.Future Work
Probably, they worth fixing.