Expand fpp-to-json tests #660
Merged
+8,179
−1,166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bocchino
approved these changes
Mar 20, 2025
There was a problem hiding this comment.
Looks good! I refactored the new fpp-to-json/fpp-check tests a bit. I moved those tests to a subdirectory. I used find instead of iterating over directories to find the fpp-check test input files. It's more efficient, and it finds files at all directory levels; before we were only going down one level. I revised the format of the test output so that the longer test names don't crash into the PASSED or FAILED output.
I also ran dostounix on the top-level source file for fpp-to-json. There were some stray ^M characters in there, probably from back when the file was created.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run fpp-to-json on fpp-check test cases to improve code coverage.
Update trace file to prevent crashes when running the fpp-to-json native build.
Closes #468.