Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.2.25 changes #797

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

0.2.25 changes #797

wants to merge 3 commits into from

Conversation

norrisjeremy
Copy link
Contributor

@norrisjeremy norrisjeremy commented Mar 20, 2025 •
edited
Loading

  • Add support for mlkem768x25519-sha256, mlkem768nistp256-sha256 & mlkem1024nistp384-sha384 KEX algorithms using JEP 496.
  • Stop abusing the packet buffer for signature verification.
  • Fix intermittent KEX errors with hybrid PQ/EC algorithms: the EC shared secret should not be stripped of unnecessary leading zero bytes since they are concatenated with the PQ secret and encoded as a string.

@norrisjeremy norrisjeremy changed the title Add support for mlkem768x25519-sha256, mlkem768nistp256-sha256 & mlkem1024nistp384-sha384 KEX algorithms using JEP 496 0.2.25 changes Mar 20, 2025
@norrisjeremy norrisjeremy marked this pull request as draft March 20, 2025 12:55
@norrisjeremy norrisjeremy force-pushed the jep496 branch 9 times, most recently from d948177 to e43e93b Compare March 21, 2025 15:40
@norrisjeremy
Add support for mlkem768x25519-sha256, mlkem768nistp256-sha256 & mlke…
37e9fa0 
…m1024nistp384-sha384 KEX algorithms using JEP 496.
@norrisjeremy norrisjeremy force-pushed the jep496 branch 7 times, most recently from 694668a to 4f8b6fa Compare March 26, 2025 17:59
@norrisjeremy
Stop abusing the packet buffer for signature verification.
48ef7d3
@norrisjeremy
Fix intermittent KEX errors with hybrid PQ/EC algorithms: the EC shar…
c985047 
…ed secret should not be stripped of unnecessary leading zero bytes since they are concatenated with the PQ secret and encoded as a string.
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
21.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@norrisjeremy norrisjeremy marked this pull request as ready for review March 26, 2025 23:46
@norrisjeremy
Copy link
Contributor Author

FYI, I believe this is finally ready to go.
I was able to finally track down the source of the intermittent failures that were occurring with the PQ/EC algorithms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@norrisjeremy