Cache ignore-for-spacing property #27248
Open
+26
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-spa
changed the title
mike-spa
force-pushed
the
cacheIgnoreForSpacingProperty
branch
2 times, most recently
from
8e875d5 to
b374fa1
Compare
mike-spa
force-pushed
the
cacheIgnoreForSpacingProperty
branch
from
b374fa1 to
3a75fb0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #27247 so that should be merged first. Not intended for 4.5.1.
As I was working on the related PR I realized that during horizontal spacing calculations we're making a lot of calls to
ignoreSegmentForSpacing(), which involves checking things on all staves all the time, which makes it quite expensive. With this PR we compute it only once and cache it for all subsequent uses.