Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preferences > Percussion: don't recreate radio buttons when changing selection #27158

Conversation

cbjeukendrup
Copy link
Contributor

@cbjeukendrup cbjeukendrup commented Mar 16, 2025

Resolves: #26488
Resolves: #19302

Copy link
Contributor

@mathesoncalum mathesoncalum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

I originally lifted a bunch of this code from the "program start" preferences section which seems to have the same problem. I Imagine a fix for that would be pretty much identical to this?

@cbjeukendrup cbjeukendrup force-pushed the prefs_perc_dont_recreate_radiobuttons branch from 9940ca6 to a1bd020 Compare March 25, 2025 19:54
@cbjeukendrup
Copy link
Contributor Author

@mathesoncalum That should be fixed now as well! The FilePicker there somehow made me think it'd be more complicated, but it isn't really :)

@zacjansheski
Copy link
Contributor

Nice improvement!

The radio button spacing in "Save & Publish" is still uneven, could that be fixed here as well?

Screenshot 2025-03-26 at 9 47 18 AM

Verified

This commit was signed with the committer’s verified signature.
cbjeukendrup Casper Jeukendrup
…selection

Verified

This commit was signed with the committer’s verified signature.
cbjeukendrup Casper Jeukendrup
…ng selection

Verified

This commit was signed with the committer’s verified signature.
cbjeukendrup Casper Jeukendrup
@cbjeukendrup cbjeukendrup force-pushed the prefs_perc_dont_recreate_radiobuttons branch from a1bd020 to 4353053 Compare March 26, 2025 22:07
@cbjeukendrup
Copy link
Contributor Author

@zacjansheski Yes, good catch, should be fixed now too!

@zacjansheski
Copy link
Contributor

Tested on MacOS 15, Windows 11, Ubuntu 22.04.3. Approved
#26488 FIXED
#19302 FIXED

@cbjeukendrup cbjeukendrup merged commit 82be822 into musescore:master Mar 27, 2025
11 checks passed
@cbjeukendrup cbjeukendrup deleted the prefs_perc_dont_recreate_radiobuttons branch March 27, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants