添加NodeJS/NPM 模块 #13
Closed
添加NodeJS/NPM 模块 #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mumuy any thoughts? |
|
你这个是链接啊，并不是代码啊！抱歉了，这个不能合并 |
|
好的，我当时的考虑是，新加代码有点多，直接把代码merge过来有污染你的repo的嫌疑，您的repo主要是维护数据，而直接吧js代码拉进来改变了原始repo的性质，要是你不介意把nodejs代码合并，我可以重发PR |
|
我只维护json版本啦，npm版本对我来说没什么用，我想让项目比较纯粹点。我要放的是数据本身，而不做工具。 |
|
Got it , 我就是直接fork的，方便更新你的数据，然后在这基础上添加node的代码，加链接的目的只是为了便于其他人寻找，所以才发的PR，：） |
|
In case someone is interested in a frontend/nodejs environment, checkout the china-location module |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
首先感谢您的整理，最近真好要用到这方面的地址信息。
为了方便nodejs同学的使用，根据您的
list.json原始数据，写了npm 模块，希望能合并，让更多的同学可以快捷使用这些数据 👨🎓 😆