New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix http server graceful shutdown #571

Merged

mtlynch merged 1 commit into mtlynch:master from phosae:fix-httpsrv-graceful-shutdown

May 17, 2024

Contributor

phosae commented May 16, 2024

as golang's http doc point out

ListenAndServe always returns a non-nil error. After Shutdown or Close

log.Fatal(httpSrv.ListenAndServe()) will cause server exit immediately with code 1, without waiting 5s for graceful shutdown.


          fix http server graceful shutdown

e9f97d1

mtlynch approved these changes

View reviewed changes

Owner

mtlynch left a comment

LGTM, thanks!

mtlynch merged commit ef57614 into mtlynch:master

9 checks passed

github-actions bot locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet