-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(re) draft Census connector #978
Conversation
Hi Charlie - looks like you're still having issues with linting. Let me know if I can help! |
Shauna thanks for the heads up! I managed to fix it but now I'm getting this error (under build) Sphinx version error: I see some discussion of this error on stackoverflow (https://stackoverflow.com/questions/77848565/sphinxcontrib-applehelp-breaking-sphinx-builds-with-sphinx-version-less-than-5-0) but I'm not sure what to do here, grateful for any pointers! Charlie |
Looks like this is an issue that Soren submitted a PR a couple weeks ago to fix: #975 If you update your branch, that should fix the issue, although note once you do that you'll want to pull those changes down to your local branch before making any additional edits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! I tested it out following your documentation and it's working for me :) Just a couple minor edits to make and we should be good to merge
docs/census.rst
Outdated
Overview | ||
******** | ||
|
||
Connects to the Census API--it has been tested with the ACS and Economic Survey endpoints. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a link to the Census API here? Also, this is super nitpicky, but do you mind editing this so there's a period instead of a double dash between the two sentences? Sorry to be such a grammar nerd 🤓
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Shauna! I fixed these and the other stuff. For the index.html file, I just downloaded the original and replaced my banged-up version :).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Going to merge now.
Draft census connector--fixed typo in index.html (thanks Austin!), linted, re-ran tests.