Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Airtable Updates #1082

Merged
merged 10 commits into from
Jul 9, 2024
Merged

Airtable Updates #1082

merged 10 commits into from
Jul 9, 2024

Conversation

codygordon
Copy link
Collaborator

@codygordon
Copy link
Collaborator Author

#950

Copy link
Collaborator

@shaunagm shaunagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, just one place that would be good to have a code comment as it's not clear what the code's doing. Once that's added I can merge this

if isinstance(table, Table):
table = table.to_dicts()

if any(isinstance(row, dict) for row in table):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment here to clarify what's happening on these two lines?

@codygordon codygordon requested a review from shaunagm June 28, 2024 13:54
@shaunagm shaunagm merged commit c3da44d into move-coop:main Jul 9, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants