-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Airtable Updates #1082
Airtable Updates #1082
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, just one place that would be good to have a code comment as it's not clear what the code's doing. Once that's added I can merge this
if isinstance(table, Table): | ||
table = table.to_dicts() | ||
|
||
if any(isinstance(row, dict) for row in table): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a comment here to clarify what's happening on these two lines?
airtable-python-wrapper
was renamed topyairtable
after v1.0. Needed to update this eventually if we want to take advantage of newer features. Seems despite a couple method name changes that it's backwards compatible.typecast
toinsert_record