Add option to disaggregate A/B test emails #1065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging @shaunagm and @matthewkrausse as interested parties. |
anzelpwj
commented
May 28, 2024
anzelpwj
commented
May 28, 2024
anzelpwj
commented
May 28, 2024
anzelpwj
commented
May 28, 2024
anzelpwj
commented
May 28, 2024
shaunagm
requested changes
May 28, 2024
shaunagm
approved these changes
Jun 6, 2024
There was a problem hiding this comment.
Can you confirm that you checked the data structures with @matthewkrausse? If yes, and if the print statement is meant to be there, I'll go ahead and merge.
test/test_van/test_email.py
Outdated
| mock_response_enriched[3]["emailMessageContent"] = sample_content_single | ||
| mock_response_enriched[4]["emailMessageContent"] = sample_content_full | ||
|
|
||
| print(mock_response_enriched) |
There was a problem hiding this comment.
Is there a reason we're printing something here, or is it left over from when you were debugging?
There was a problem hiding this comment.
That was probably a holdover from testing things in a notebook. Will delete. The data structures I got directly from @matthewkrausse , just with a bit of field value changing (so it didn't have GGT data in it).
There was a problem hiding this comment.
Perfect, just @ me once you've done that and I'll merge
shaunagm
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1059 - this gives us an optional parameter to the NGP email endpoint that lets us dis-aggregate A/B test results from the endpoint. I also did a bit of code cleanup and added some tests.