-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Features - ActionNetwork API - Unique ID Lists routes support + SQL Mirror support #1025
Features - ActionNetwork API - Unique ID Lists routes support + SQL Mirror support #1025
Conversation
…s-actionnetwork-changes
…s-actionnetwork-changes
…dvocacy Campaigns, Attendances, Campaigns, Custom Fields, Donations, Embeds, Event Campaigns, Events, Forms, Fundraising Pages, Items, Lists, Messages, Metadata, Outreaches, People, Petitions, Queries, Signatures, Submissions, Tags, Taggings, Wrappers)
…s-actionnetwork-changes
…s-actionnetwork-changes
…h function in module)
…s-actionnetwork-changes
78099e9
to
7ec0f32
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good (to the extent that I understand the db connectors) but I'd like feedback on why "parsons.action_network.action_network" was changed
…s-actionnetwork-changes
…ng with using the redshift conector there instead of just connecting with psycopg and SSHTunnelForwader
…ng with using the redshift conector there instead of just connecting with psycopg and SSHTunnelForwader2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, although I'm not the best person to review the database connectors.
… + SQL Mirror support (move-coop#1025)" This reverts commit 33b7185.
Hey @NirTatcher , it looks like we can't re-open this PR as is, can you set up a new PR with these changes? They were reverted from the main branch because they cause some breaking changes which need to be fixed before they can be merged. |
I can add a review specifying those changes if you open a new PR |
@shaunagm could you please let me know if there are any questions on the new additions or if I missed/need to add anything?
PS:
SSHTunnelUtility
(utilities/ssh_utilities).