Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Windows build support #54

Merged
merged 1 commit into from
Feb 19, 2025
Merged

Conversation

daschiller
Copy link
Contributor

Tested and working.

I did not add it to the default target or to the CI, since I am not sure if you want to release Windows binaries.

@mostlygeek
Copy link
Owner

Windows isn't well supported by llama-swap because it expects Unix style processes and signals. The project would need some windows specific swapping tests before distributing a build for it.

@daschiller
Copy link
Contributor Author

I've been running it for the past few days without any issues. It can swap between models and kill spawned processes after TTL expiry. The only problem I ran into was having to escape backslashes for paths in the cmd option, but that's not unusual.

@mostlygeek
Copy link
Owner

mostlygeek commented Feb 19, 2025

I managed to test it on a windows PC today and it worked better than I expected it to. Much to my surprise. Thanks for the PR.

Also adding a windows binary to the release build since it seems to work well enough.

@mostlygeek mostlygeek merged commit 7187cfe into mostlygeek:main Feb 19, 2025
mostlygeek added a commit that referenced this pull request Feb 19, 2025

Verified

This commit was signed with the committer’s verified signature.
mostlygeek Benson Wong
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants