Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Dump Goroutines to logger #90

Closed
zhangqibupt opened this issue Mar 29, 2022 · 4 comments
Closed

Support Dump Goroutines to logger #90

zhangqibupt opened this issue Mar 29, 2022 · 4 comments
Assignees
@Jun10ng

Comments

@zhangqibupt
Copy link

Currently, the goroutines are dumped into specified file path, sometimes it might be hard for us to check.
Is it possible to support to dump goroutines to logger? If so we can see check it in our existing log system(ELK). Thanks.
@doujiang24
Copy link
Member

I think it's not a good idea to dump profile to logger, since the profile always will be big.
But it also sounds reasonable, I'm not against it.

PR welcome!
Or, do you guys are interested to support it? @Jun10ng @songzhibin97

@Jun10ng Jun10ng assigned zhangqibupt and Jun10ng and unassigned zhangqibupt Mar 29, 2022
Jun10ng added a commit to Jun10ng/holmes that referenced this issue Mar 29, 2022
@Jun10ng
feat:supports groutine dump on logger(mosn#90)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
e76d4ce
@Jun10ng Jun10ng mentioned this issue Mar 29, 2022
Merged
@Jun10ng
Copy link
Contributor

Jun10ng commented Mar 29, 2022

follow into #91

@Jun10ng Jun10ng closed this as completed Mar 29, 2022
Jun10ng added a commit to Jun10ng/holmes that referenced this issue Mar 30, 2022
@Jun10ng
feat:supports groutine dump on logger(mosn#90)
2cfcad4
Jun10ng added a commit to Jun10ng/holmes that referenced this issue Mar 30, 2022
@Jun10ng
feat:supports cpu dump on logger(mosn#90)
07f1ba2
Jun10ng added a commit to Jun10ng/holmes that referenced this issue Mar 31, 2022
@Jun10ng
refine:refine log(mosn#90)
83858d8
Jun10ng added a commit to Jun10ng/holmes that referenced this issue Mar 31, 2022
@Jun10ng
refine:add docs(mosn#90)
1da6793
@zhangqibupt
Copy link
Author

Thank you guys, you are the best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jun10ng Jun10ng

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@doujiang24 @zhangqibupt @Jun10ng and others