Improve Error Checking Code

.editorconfig

@@ -86,3 +86,7 @@ dotnet_diagnostic.IDE0055.severity = suggestion
 
 # IDE0046: Convert to conditional expression
 dotnet_diagnostic.IDE0046.severity = suggestion
+
+# Inform the CA1062 analyzer that Guard.IsNotNull will do null-check for us
+# CA1062: Validate arguments of public methods
+dotnet_code_quality.CA1062.null_check_validation_methods = IsNotNull

MoreLinq.Test/Extensions.cs

@@ -17,6 +17,7 @@
 
 namespace MoreLinq.Test
 {
+    using CommunityToolkit.Diagnostics;
     using System;
     using System.Diagnostics;
     using System.Globalization;
@@ -39,7 +40,7 @@ public static string ToInvariantString<T>(this T formattable) where T : IFormatt
         [DebuggerStepThrough]
         public static string ToInvariantString<T>(this T formattable, string? format) where T : IFormattable
         {
-            if (formattable is null) throw new ArgumentNullException(nameof(formattable));
+            Guard.IsNotNull(formattable);
             return formattable.ToString(format, CultureInfo.InvariantCulture);
         }
     }

MoreLinq.Test/NullArgumentTest.cs

@@ -17,6 +17,7 @@
 
 namespace MoreLinq.Test
 {
+    using CommunityToolkit.Diagnostics;
     using System;
     using System.Collections;
     using System.Collections.Generic;
@@ -56,9 +57,20 @@ static IEnumerable<ITestCaseData> GetNotNullTestCases() =>
                 Assert.That(e, Is.InstanceOf<ArgumentNullException>().With.Property(nameof(ArgumentNullException.ParamName)).EqualTo(paramName));
                 Debug.Assert(e is not null);
                 var stackTrace = new StackTrace(e, false);
-                var stackFrame = stackTrace.GetFrames().First();
-                var actualType = stackFrame.GetMethod()?.DeclaringType;
-                Assert.That(actualType, Is.SameAs(typeof(MoreEnumerable)));
+                var stackFrames = stackTrace.GetFrames();
+
+                // `Guard.IsNotNull()` adds additional stack frames
+                // so find first non-CommunityToolkit.Diagnostics
+                for (var i = 0; i < stackFrames.Length; i++)
+                {
+                    var actualType = stackFrames[i]?.GetMethod()?.DeclaringType;
+                    if (actualType?.Namespace != "CommunityToolkit.Diagnostics")
+                    {
+                        // top _non_-`Guard` should be `MoreEnumerable`
+                        Assert.That(actualType, Is.SameAs(typeof(MoreEnumerable)));
+                        break;
+                    }
+                }
             });
 
         static IEnumerable<ITestCaseData> GetCanBeNullTestCases() =>
@@ -226,7 +238,7 @@ public sealed class OrderedEnumerable<T> : Enumerable<T>, System.Linq.IOrderedEn
             {
                 public System.Linq.IOrderedEnumerable<T?> CreateOrderedEnumerable<TKey>(Func<T, TKey> keySelector, IComparer<TKey>? comparer, bool descending)
                 {
-                    if (keySelector == null) throw new ArgumentNullException(nameof(keySelector));
+                    Guard.IsNotNull(keySelector);
                     return this;
                 }
             }

MoreLinq.Test/PadStartTest.cs

@@ -29,7 +29,7 @@ public class PadStartTest
         [Test]
         public void PadStartWithNegativeWidth()
         {
-            Assert.That(() => new int[0].PadStart(-1), Throws.ArgumentException("width"));
+            Assert.That(() => new int[0].PadStart(-1), Throws.ArgumentOutOfRangeException("width"));
         }
 
         [Test]
@@ -64,7 +64,7 @@ public void ReferenceTypeElements(ICollection<string?> source, int width, IEnume
         [Test]
         public void PadStartWithPaddingWithNegativeWidth()
         {
-            Assert.That(() => new int[0].PadStart(-1, 1), Throws.ArgumentException("width"));
+            Assert.That(() => new int[0].PadStart(-1, 1), Throws.ArgumentOutOfRangeException("width"));
         }
 
         [Test]
@@ -99,7 +99,7 @@ public void ReferenceTypeElements(ICollection<string> source, int width, IEnumer
         [Test]
         public void PadStartWithSelectorWithNegativeWidth()
         {
-            Assert.That(() => new int[0].PadStart(-1, x => x), Throws.ArgumentException("width"));
+            Assert.That(() => new int[0].PadStart(-1, x => x), Throws.ArgumentOutOfRangeException("width"));
         }
 
         [Test]

MoreLinq.Test/PadTest.cs

@@ -25,7 +25,7 @@ public class PadTest
         [Test]
         public void PadNegativeWidth()
         {
-            Assert.That(() => new object[0].Pad(-1), Throws.ArgumentException("width"));
+            Assert.That(() => new object[0].Pad(-1), Throws.ArgumentOutOfRangeException("width"));
         }
 
         [Test]

MoreLinq.Test/SequenceReader.cs

@@ -17,14 +17,15 @@
 
 namespace MoreLinq.Test
 {
+    using CommunityToolkit.Diagnostics;
     using System;
     using System.Collections.Generic;
 
     static class SequenceReader
     {
         public static SequenceReader<T> Read<T>(this IEnumerable<T> source)
         {
-            if (source == null) throw new ArgumentNullException(nameof(source));
+            Guard.IsNotNull(source);
             return new SequenceReader<T>(source);
         }
     }
@@ -59,7 +60,7 @@ public SequenceReader(IEnumerator<T> enumerator) =>
 
         static IEnumerator<T> GetEnumerator(IEnumerable<T> source)
         {
-            if (source == null) throw new ArgumentNullException(nameof(source));
+            Guard.IsNotNull(source);
             return source.GetEnumerator();
         }
 

MoreLinq/Acquire.cs

@@ -17,6 +17,7 @@
 
 namespace MoreLinq
 {
+    using CommunityToolkit.Diagnostics;
     using System;
     using System.Collections.Generic;
 
@@ -41,7 +42,7 @@ static partial class MoreEnumerable
         public static TSource[] Acquire<TSource>(this IEnumerable<TSource> source)
             where TSource : IDisposable
         {
-            if (source == null) throw new ArgumentNullException(nameof(source));
+            Guard.IsNotNull(source);
 
             var disposables = new List<TSource>();
             try