fix(cli-repl): use tls allowPartialTrustChain flag MONGOSH-1878 #2181
Conversation
This should bring back startup performance to pre-2.3.1 levels. Also pins kerberos to 2.1.0, since bumping it actually broke our Windows build.
There was a problem hiding this comment.
As the filename indicates, this is nodejs/node@1b34202 and can be removed once we adopt the next Node.js 20.x release
There was a problem hiding this comment.
Seems like the 20.18.0 got released in the meantime. Should we merge #2190 instead of manually applying the patch, or is it still helpful to have the manual patch for some other use case?
There was a problem hiding this comment.
The most recent CI for #2190 failed – it's no longer visible because the GH bot force-pushes, here's the link: https://spruce.mongodb.com/version/66ff36e5cad15800072c4869/tasks
That's failing because of a conflict with another of our source patches, so I'll just go ahead and merge this, then create a PR based on #2190 that removes the patch again and fixes whatever else needs fixing
addaleax
force-pushed
the
apply-tls-allowpartialtrustchain
branch
from
cb0c6ed to
29c9c2b
Compare
addaleax
changed the title
This should bring back startup performance to pre-2.3.1 levels.
Also pins kerberos to 2.1.0, since bumping it actually broke our Windows build.