Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix react bridge for react 16 #3591

Merged

Conversation

CarltonHowell
Copy link
Contributor

@CarltonHowell CarltonHowell commented Mar 13, 2025

Description

  • React-bridge is failing when used with React 16 versions before 16.13.0.
  • Check to see if ReactDom.version property exists in isReact18 check. React versions before 16.13.0 do not have this prop.

Related Issue

#3592

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

Copy link

changeset-bot bot commented Mar 13, 2025

🦋 Changeset detected

Latest commit: d517175

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@module-federation/bridge-react Patch
@module-federation/runtime Patch
@module-federation/enhanced Patch
@module-federation/rspack Patch
@module-federation/webpack-bundler-runtime Patch
@module-federation/sdk Patch
@module-federation/runtime-tools Patch
@module-federation/managers Patch
@module-federation/manifest Patch
@module-federation/dts-plugin Patch
@module-federation/third-party-dts-extractor Patch
@module-federation/devtools Patch
@module-federation/bridge-vue3 Patch
@module-federation/bridge-shared Patch
@module-federation/bridge-react-webpack-plugin Patch
@module-federation/modern-js Patch
@module-federation/retry-plugin Patch
@module-federation/data-prefetch Patch
@module-federation/rsbuild-plugin Patch
@module-federation/error-codes Patch
@module-federation/inject-external-runtime-core-plugin Patch
@module-federation/runtime-core Patch
create-module-federation Patch
@module-federation/nextjs-mf Patch
@module-federation/node Patch
@module-federation/storybook-addon Patch
@module-federation/modernjsapp Patch
@module-federation/esbuild Patch
@module-federation/utilities Patch
website-new Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Mar 13, 2025

Deploy Preview for module-federation-docs ready!

Name Link
🔨 Latest commit d517175
🔍 Latest deploy log https://app.netlify.com/sites/module-federation-docs/deploys/67d4e85bb398dd0008d6a6dc
😎 Deploy Preview https://deploy-preview-3591--module-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ScriptedAlchemy
Copy link
Member

please run changeset add

@douglaszaltron
Copy link
Contributor

douglaszaltron commented Mar 14, 2025

@CarltonHowell I would recommend making a more semantic commit, so it would be better visualized on the main branch. Ex: feat(bridge-react): safeguard React version check with optional chaining.

@ScriptedAlchemy
Copy link
Member

fix / patch is what id suggest - since we are in v0 semver range, we use the minor as "major feature / potential breaking" and we use patch for Feature/Fix

@danpeen danpeen merged commit 2d086fc into module-federation:main Mar 16, 2025
14 checks passed
@2heal1 2heal1 mentioned this pull request Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants