fix(enhanced): reuse cached runtime entry #3522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 203180a The changes in this PR will be included in the next version bump. This PR includes changesets to release 29 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -193,6 +201,10 @@ class FederationRuntimePlugin { | |||
| ), | |||
| )}`; | |||
| } | |||
|
|
|||
| if (!existedFilePath) { | |||
| onceForCompilerEntryMap.set(compiler, this.entryFilePath); | |||
There was a problem hiding this comment.
Is there going to be a way to mark a entryFilePath as changed?
There was a problem hiding this comment.
entry file path should never change since its a virtual module we generate, any change to it would require the compiler to restart anywys since the entry file is generated during compiler startup
2heal1
force-pushed
the
fix/runtime-plugins
branch
from
e388808 to
d1e5534
Compare
zhoushaw
approved these changes
Feb 19, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
reuse cached runtime entry
Related Issue
Types of changes
Checklist