Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/use bun as a package manager and script runner #2148

Merged

Conversation

coolsoftwaretyler
Copy link
Collaborator

@coolsoftwaretyler coolsoftwaretyler commented Feb 21, 2024

What does this PR do and why?

This PR will supercede #2103 so we can more easily pull in the TypeScript upgrades from #2103.

It swaps us over to using Bun as a package manager and script runner for MobX-State-Tree development.

There should be no downstream effects of this change. All scripts from package.json are compatible with Bun, but now our dependency downloads are much much faster than with yarn. This also opens the door to using the Bun test runner which is faster than Jest, and understands TypeScript by default.

I updated the docs to point people to Bun for these commands, as opposed to Yarn. And I updated our CircleCI jobs to use Bun as well (probably needs some iteration - I will check during the CI stage of this PR).

Steps to validate locally

Pull this down, remove your node_modules folder, and run bun install (assuming you already have Bun on your machine. Run any and all scrips from package.json and you'll see it all works with bun run as opposed to yarn. You can just go from top to bottom in the scripts block and verify things work as expected.

While running these tests, I also:

  1. Fixed some prettier issues in two test files
  2. Deployed the docs (that's why there are docs/API/ diffs in this PR

@coolsoftwaretyler coolsoftwaretyler changed the title Chore/use bun a package manager and script runner Chore/use bun as a package manager and script runner Feb 21, 2024
@coolsoftwaretyler coolsoftwaretyler merged commit 711e182 into master Feb 21, 2024
1 check passed
@coolsoftwaretyler coolsoftwaretyler deleted the chore/use-bun-a-package-manager-and-script-runner branch February 21, 2024 16:24
coolsoftwaretyler added a commit that referenced this pull request Feb 26, 2024
* chore: use bun for package management

* chore: update contributing docs to point to Bun

* chore: try to use Bun in CircleCI rather than yarn

* chore: use bun in pre-commit hook instead of yarn

* chore: update package json scripts to bun

* chore: prettier:write on some tests

* chore: run publish-docs

* fix: circle CI typos

* fix: install bun in Circle CI test runners
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant