Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Windows System libraries with find_library #14498

Open
wants to merge 1 commit into
base: 2.5
Choose a base branch
from

Conversation

daschuer
Copy link
Member

@daschuer daschuer commented Mar 19, 2025

This aims to not require the VS 2022 shell after the build directory is configured.

This shall avoid this error message:

FAILED: mixxx.exe
C:\WINDOWS\system32\cmd.exe /C "cd . && "C:\Program Files\CMake\bin\cmake.exe" -E vs_link_exe --msvc-ver=1943 --intdir=CMakeFiles\mixxx.dir --rc=C:\PROGRA~2\WI3CF2~1\10\bin\100220~1.0\x64\rc.exe --mt=C:\PROGRA~2\WI3CF2~1\10\bin\100220~1.0\x64\mt.exe --manifests  -- C:\PROGRA~1\MIB055~1\2022\COMMUN~1\VC\Tools\MSVC\1443~1.348\bin\Hostx64\x64\link.exe /nologo @CMakeFiles\mixxx.rsp  /out:mixxx.exe /implib:mixxx.lib /pdb:mixxx.pdb /version:0.0 /machine:x64 /debug /INCREMENTAL:NO /subsystem:windows /OPT:REF /entry:mainCRTStartup /manifest && C:\WINDOWS\system32\cmd.exe /C "cd /D C:\GitHub\mixxx\build && C:\Windows\System32\WindowsPowerShell\v1.0\powershell.exe -noprofile -executionpolicy Bypass -file C:/GitHub/mixxx/buildenv/mixxx-deps-2.5-x64-windows-c15790e/scripts/buildsystems/msbuild/applocal.ps1 -targetBinary C:/GitHub/mixxx/build/mixxx.exe -installedDir C:/GitHub/mixxx/buildenv/mixxx-deps-2.5-x64-windows-c15790e/installed/x64-windows/bin -OutVariable out && cd /D C:\GitHub\mixxx\build && "C:\Program Files\CMake\bin\cmake.exe" -DCOMPONENT=applocal -DCMAKE_INSTALL_PREFIX="C:/GitHub/mixxx/build" -P cmake_install.cmake""
LINK: command "C:\PROGRA~1\MIB055~1\2022\COMMUN~1\VC\Tools\MSVC\1443~1.348\bin\Hostx64\x64\link.exe /nologo @CMakeFiles\mixxx.rsp /out:mixxx.exe /implib:mixxx.lib /pdb:mixxx.pdb /version:0.0 /machine:x64 /debug /INCREMENTAL:NO /subsystem:windows /OPT:REF /entry:mainCRTStartup /manifest /MANIFEST:EMBED,ID=1" failed (exit code 1181) with the following output:
LINK : fatal error LNK1181: cannot open input file 'comctl32.lib'
ninja: build stopped: subcommand failed.
``

@github-actions github-actions bot added the build label Mar 19, 2025
@daschuer
Copy link
Member Author

Cool, can you confirm the issue is gone?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants