Improve STEM support on Windows and Mac #14392
Conversation
acolombier
force-pushed
the
chore/stem-on-win-and-macos
branch
from
e0577b5 to
4aaffd9
Compare
| @@ -116,13 +116,28 @@ bool StemInfoImporter::maybeStemFile( | |||
| mimeType = QMimeDatabase().mimeTypeForFile( | |||
| fileName, QMimeDatabase::MatchContent); | |||
| } | |||
|
|
|||
| // On Windows (at least), the MIME detection seems to sometime detect stem file | |||
| // as `video/quicktime` so we always try and detect from the extension | |||
There was a problem hiding this comment.
Interesting, have you an Idea why this happens and why it happens only on windows?
There was a problem hiding this comment.
No, no idea. This is the ffprobe of the file I used for testing
ffprobe version 7.0.2 Copyright (c) 2007-2024 the FFmpeg developers
[...]
libavutil 59. 8.100 / 59. 8.100
libavcodec 61. 3.100 / 61. 3.100
libavformat 61. 1.100 / 61. 1.100
libavdevice 61. 1.100 / 61. 1.100
libavfilter 10. 1.100 / 10. 1.100
libswscale 8. 1.100 / 8. 1.100
libswresample 5. 1.100 / 5. 1.100
libpostproc 58. 1.100 / 58. 1.100
Input #0, mov,mp4,m4a,3gp,3g2,mj2, from '/home/antoine/Music/Stems/Afroki - Save My Soul (feat. Jordan Grace).stem.mp4':
Metadata:
major_brand : isom
minor_version : 512
compatible_brands: isomiso2mp41
encoder : Lavf58.76.100
Duration: 00:03:28.04, start: 0.000000, bitrate: 1287 kb/s
Stream #0:0[0x1](und): Audio: aac (libfdk_aac) (mp4a / 0x6134706D), 44100 Hz, stereo, s16, 255 kb/s (default)
Metadata:
handler_name : SoundHandler
vendor_id : [0][0][0][0]
Stream #0:1[0x2](und): Audio: aac (libfdk_aac) (mp4a / 0x6134706D), 44100 Hz, stereo, s16, 256 kb/s
Metadata:
handler_name : SoundHandler
vendor_id : [0][0][0][0]
Stream #0:2[0x3](und): Audio: aac (libfdk_aac) (mp4a / 0x6134706D), 44100 Hz, stereo, s16, 255 kb/s
Metadata:
handler_name : SoundHandler
vendor_id : [0][0][0][0]
Stream #0:3[0x4](und): Audio: aac (libfdk_aac) (mp4a / 0x6134706D), 44100 Hz, stereo, s16, 256 kb/s
Metadata:
handler_name : SoundHandler
vendor_id : [0][0][0][0]
Stream #0:4[0x5](und): Audio: aac (libfdk_aac) (mp4a / 0x6134706D), 44100 Hz, stereo, s16, 256 kb/s
Metadata:
handler_name : SoundHandler
vendor_id : [0][0][0][0]
I have shared the file on our GDrive
There was a problem hiding this comment.
As I was testing #13470 on Windows with the stem file (and without this patch), the MIME was successfully detected so it does look like random bug.
I would suggest we keep this fix, but since I don't use Windows, I'm not too opinionated and happy to drop it if we think it was a one off
There was a problem hiding this comment.
I could reproduce this with the new buildenv, but I've never seen this with the old. Does this work with Qt 6.8 on Linux? For me it looks like different behaviour between different Qt versions, not like a platform issue.
There were some quite significiant changes in QMimeDatabase in Qt6.8: qt/qtbase@74ad4cb#diff-e2f8422be8a7c90c098da145e8709add8acfb7c49571bdf3c6d482d777aa8f29
There was a problem hiding this comment.
It works on Fedora with Qt 6.8, also seems to work on my Hackintosh too.
There was a problem hiding this comment.
Do you have Freedesktops shared-mime-info-spec installed on the Fedora system with Qt6.8? Can it be, that Qt uses this instead of the new Apache tika-mimetypes that comes with Qt6.8?
There was a problem hiding this comment.
No idea, but I do indeed have shared-mime-info installed out of the box on Fedora (and on Ubuntu with Dev Container which I use nowadays) so you could be right
acolombier
changed the title
github-actions
bot
added
the
developer experience
acolombier
force-pushed
the
chore/stem-on-win-and-macos
branch
from
2bbfd44 to
0873704
Compare
acolombier
force-pushed
the
chore/stem-on-win-and-macos
branch
from
0873704 to
e98299d
Compare
|
Looks like there is some warnings introduce in the protobuf libs - any advice here? Shall we disable |
|
We use party stopper lable for bugs that will stop a party. This is not the case here. |
|
Ah sorry - I meant to flag this as a "must" for the 2.6 release. Should I use |
Waiting for mixxxdj/vcpkg#153