Decompose measurement in QIR Base profile processing #2230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change simplifies the decomposition of `M` and `Measure` in the stdlib to no longer conditionally compile to different versions based on qubit reuse capability, instead offloading that to QIR processing, which already has similar logic. One effect of this is simulation and circuit generation will match user expectation and patterns in the Q# code rather than more closely showing what occurs on hardware.
swernli
requested review from
billti,
idavis,
minestarks and
DmitryVasilevsky
as code owners
|
Change in memory usage detected by benchmark. Memory Report for 517a0e1
|
|
Change in memory usage detected by benchmark. Memory Report for 88ad901
|
minestarks
approved these changes
Mar 13, 2025
|
Forgot to add before I signed off: Can we update the circuit UI to remove the target profile information since it's no longer relevant? |
Well, it's no longer relevant for most bits but it could still be relevant for conditionally compiled code from librarys or the user's own code. Since it's not too obtrusive, I'd be in favor of leaving it. But I could be convinced ;). |
|
Change in memory usage detected by benchmark. Memory Report for 01cf761
|
idavis
approved these changes
Mar 19, 2025
swernli
added a commit
that referenced
this pull request
Mar 31, 2025
Now that the measurement decompositions are handled lower in the stack (see #2230), the examples for how measurements show up differently for circuits from Base profile vs Unrestricted no longer make sense. This removes them. Likewise the section in the wiki on circuits for different profiles should be updated or removed (see https://github.com/microsoft/qsharp/wiki/Circuit-Diagrams-from-Q%23-Code#target-profile)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 31, 2025
Now that the measurement decompositions are handled lower in the stack (see #2230), the examples for how measurements show up differently for circuits from Base profile vs Unrestricted no longer make sense. This removes them. <s>Likewise the section in the wiki on circuits for different profiles should be updated or removed (see https://github.com/microsoft/qsharp/wiki/Circuit-Diagrams-from-Q%23-Code#target-profile)</s> Done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change simplifies the decomposition of
MandMeasurein the stdlib to no longer conditionally compile to different versions based on qubit reuse capability, instead offloading that to QIR processing, which already has similar logic.One effect of this is simulation and circuit generation will match user expectation and patterns in the Q# code rather than more closely showing what occurs on hardware.