Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AssistantAgent.metadata for user/application identity information associated with the agent. #6048 #6057

Merged
merged 11 commits into from
Mar 23, 2025

Conversation

tongyu0924
Copy link
Contributor

@tongyu0924 tongyu0924 commented Mar 21, 2025

Why are these changes needed?

This PR introduces a metadata field in AssistantAgentConfig, allowing applications to assign and track identity information for agents.
The metadata field is a Dict[str, str] and is included in the configuration for proper serialization.

Related issue number

Closes #6048

Checks

@tongyu0924 tongyu0924 closed this Mar 21, 2025
@tongyu0924 tongyu0924 reopened this Mar 21, 2025
Copy link
Collaborator

@ekzhu ekzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just the API docs need to be updated as well.

@tongyu0924
Copy link
Contributor Author

Looks good. Just the API docs need to be updated as well.

I've modified it, but I'm not sure if it's correct

@ekzhu
Copy link
Collaborator

ekzhu commented Mar 22, 2025

Looks good. Just the API docs need to be updated as well.

I've modified it, but I'm not sure if it's correct

It's not. The api doc is the doc string of AssistantAgent

@tongyu0924
Copy link
Contributor Author

Looks good. Just the API docs need to be updated as well.

I've modified it, but I'm not sure if it's correct

It's not. The api doc is the doc string of AssistantAgent

I've added the metadata docstring to AssistantAgent — could you help confirm if the wording is correct?

Copy link

codecov bot commented Mar 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.65%. Comparing base (fc2c997) to head (9e199a3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6057   +/-   ##
=======================================
  Coverage   76.64%   76.65%           
=======================================
  Files         191      191           
  Lines       13220    13222    +2     
=======================================
+ Hits        10133    10135    +2     
  Misses       3087     3087           
Flag Coverage Δ
unittests 76.65% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ekzhu
Copy link
Collaborator

ekzhu commented Mar 23, 2025

Please run poe format to fix formatting issues.

@tongyu0924
Copy link
Contributor Author

Please run poe format to fix formatting issues.

I’ve run poe format and pushed the changes.

@ekzhu ekzhu merged commit 47ffacc into microsoft:main Mar 23, 2025
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AssistantAgent.metadata for user/application identity information associated with the agent.
2 participants