Add support for jsconfig.json in language service #6545
Conversation
| @@ -493,8 +493,9 @@ namespace ts { | |||
| * @param basePath A root directory to resolve relative path entries in the config | |||
| * file to. e.g. outDir | |||
| */ | |||
| export function parseJsonConfigFileContent(json: any, host: ParseConfigHost, basePath: string, existingOptions: CompilerOptions = {}): ParsedCommandLine { | |||
There was a problem hiding this comment.
this is going to be an API breaking change. can we add an optional argument for the filename?
| @@ -1026,10 +1026,16 @@ namespace ts.server { | |||
| // the newly opened file. | |||
| findConfigFile(searchPath: string): string { | |||
There was a problem hiding this comment.
There's a findConfigFile function in program.ts also which only looks for tsconfig.json currently. This appear to only be used by the tsc command-line compiler though, so not needed for this review. Please add an issue to fix it though for the effort to compiler JavaScript at the command line (issue #4792).
There was a problem hiding this comment.
Opened issue #6561 for further discussion
| const options: CompilerOptions = {}; | ||
| const errors: Diagnostic[] = []; | ||
|
|
||
| if (configFileName && getBaseFileName(configFileName) === "jsconfig.json") { | ||
| options.allowJs = true; |
There was a problem hiding this comment.
Default "module" to "commonjs" also for jsconfig.json files, as by default we infer CommonJS from require calls or exports assignments, and also this will allow usage of ES6 syntax without getting errors about setting the module type (which is mostly needed for emit, which usually doesn't apply in the .js case).
|
One more change, then 👍 |
Add support for jsconfig.json in language service
This PR adds support for
jsconfig.jsonin the language service. The implementation treatsjsconfig.jsonas atsconfig.jsonfile with theallowJscompiler option set totrue.Edit by @DanielRosenwasser: Fixes #6561.